Adjust Spring Pulsar test to use 'interceptorsCustomizers' field #39946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
The PulsarTemplate recently replaced its list of ProducerInterceptors with a list of ProducerBuilderCustomizers that customize the builder by adding each interceptor to the builder. The PulsarAutoConfigurationTests previosuly relied on the previous field. This commit adjusts the tests to instead use the Customizers testing utility to verify the interceptors. See spring-projectsgh-39912 (cherry picked from commit 9c054a0)
onobc
force-pushed
the
cbono-pulsar-adjust-interceptor-tests
branch
from
9b983cd to
be64d5e
Compare
mhalbritter
added
type: task
mhalbritter
pushed a commit
that referenced
this pull request
Mar 15, 2024
The PulsarTemplate recently replaced its list of ProducerInterceptors with a list of ProducerBuilderCustomizers that customize the builder by adding each interceptor to the builder. The PulsarAutoConfigurationTests previosuly relied on the previous field. This commit adjusts the tests to instead use the Customizers testing utility to verify the interceptors. (cherry picked from commit 9c054a0) See gh-39946
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spring Pulsar 1.0.4-SNAPSHOT now includes a fix to properly cache any user-provided producer interceptors.
The fix changes an internal implementation detail of 'PulsarTemplate'. The 'List interceptors'
field is now 'List<ProducerBuilderCustomizer> interceptorsCustomizers'. This commit adjusts the PulsarAutoConfigurationTests to use the new list of interceptor customizers.