Suggestion for improvement to documentation #3321
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the shading of dependencies into jars which may or may not be true uber jars
philwebb
added
type: enhancement
philwebb
added a commit
that referenced
this pull request
Jun 25, 2015
* pr/3321: Update documentation to remove 'shaded jar' term
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation discusses shaded jars and uber jars as though the terms were interchangeable, but the "shading" concept refers more specifically to the renaming of some subset of the project's dependencies, usually to sidestep the "jar hell" issue in some way, e.g. when some OSS project releases incompatible versions of the same FQ class. I have reworded the section in question to avoid the shading notion altogether.