Skip to content

Conversation

@wonwoo
Copy link
Contributor

@wonwoo wonwoo commented Mar 2, 2022

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 2, 2022
@snicoll
Copy link
Member

snicoll commented Mar 2, 2022

@wonwoo this is a Long attribute so naming it user doesn't feel right. That really is the user identifier, hence the current code is better. Thanks for the PR, in any case.

@snicoll snicoll closed this Mar 2, 2022
@snicoll snicoll added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 2, 2022
@wonwoo
Copy link
Contributor Author

wonwoo commented Mar 2, 2022

I think this example is wrong.
Cannot resolve path variable user

@GetMapping("/{user}") 

from

@GetMapping("/{userId}") 

What do you think?

@snicoll snicoll reopened this Mar 2, 2022
@snicoll
Copy link
Member

snicoll commented Mar 2, 2022

Thanks for the follow-up. You are right that the mapping is wrong, I overlooked that, sorry.

I don't think that we should rename the variables as I find them a bit confusing. Rather I'd rename the path variable pattern to use {userId} rather than `{user}. Would you be willing to update your PR in that direction?

@snicoll snicoll added status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged and removed status: declined A suggestion or change that we don't feel we should currently apply labels Mar 2, 2022
@wonwoo
Copy link
Contributor Author

wonwoo commented Mar 2, 2022

please review again!
thank!

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Mar 2, 2022
@wilkinsona wilkinsona changed the title fix typo in documents Polish RestController examples Mar 2, 2022
@wilkinsona wilkinsona added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels Mar 2, 2022
@wilkinsona wilkinsona added this to the 2.5.x milestone Mar 2, 2022
@snicoll snicoll changed the title Polish RestController examples Fix PathVariable name in web examples Mar 2, 2022
@snicoll snicoll changed the title Fix PathVariable name in web examples Polish web examples in reference doc Mar 2, 2022
@wilkinsona wilkinsona self-assigned this Mar 3, 2022
@wilkinsona wilkinsona modified the milestones: 2.5.x, 2.5.11 Mar 3, 2022
@wilkinsona
Copy link
Member

Thanks very much, @wonwoo.

wilkinsona pushed a commit that referenced this pull request Mar 3, 2022
@wilkinsona wilkinsona closed this in ef92762 Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: documentation A documentation update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants