Skip to content

Conversation

@raviu
Copy link
Contributor

@raviu raviu commented Dec 13, 2021

Addresses enhancement issue #28918

Adds AbstractJdbcConfiguration to default includes.

@pivotal-cla
Copy link

@raviu Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@raviu Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 13, 2021
@snicoll snicoll added the status: on-hold We can't start working on this issue yet label Dec 14, 2021
@mbhave mbhave added type: enhancement A general enhancement and removed status: on-hold We can't start working on this issue yet status: waiting-for-triage An issue we've not yet triaged labels Dec 14, 2021
@mbhave mbhave added this to the 2.7.x milestone Dec 14, 2021
@snicoll snicoll self-assigned this Jan 4, 2022
@snicoll snicoll modified the milestones: 2.7.x, 2.7.0-M1 Jan 4, 2022
@snicoll snicoll closed this in af933f2 Jan 4, 2022
@snicoll
Copy link
Member

snicoll commented Jan 4, 2022

@raviu thank you for making your first contribution to Spring Boot.

@CichonPawel
Copy link

until now, @DataJdbcTest did not need a dependency to spring-boot-starter-data-jdbc. I think this is a non-intuitive change. Many people will wonder why they got:
Caused by: java.lang.NoClassDefFoundError: org/springframework/data/jdbc/repository/config/AbstractJdbcConfiguration

@snicoll
Copy link
Member

snicoll commented Aug 23, 2022

slice test annotations can't bring a dependency when they're used. The issue addressed an inconsistency with regards to @DataJdbcTest. If you want to test the JDBC slice of your app and you don't want to use Spring Data, you have to use @JdbcTest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants