Skip to content

Conversation

@Meijuh
Copy link
Contributor

@Meijuh Meijuh commented Jul 24, 2021

This commit adds configuration to the Maven and Gradle plugins to
allow specifying the network mode to be provided to the image
building goal and task. This behavior is equivalent to the
"pack --network ..." option.

Fixes gh-25876

This commit adds configuration to the Maven and Gradle plugins to
allow specifying the network mode to be provided to the image
building goal and task. This behavior is equivalent to the
"pack --network ..." option.

Fixes spring-projectsgh-25876
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 24, 2021
@snicoll
Copy link
Member

snicoll commented Jul 26, 2021

Thanks for the PR. Regarding #25876 (comment), the reference documentation of both plugins are located in src/docs/asciidoc and building the module also generates the doc in build/docs/asciidoc.

@Meijuh
Copy link
Contributor Author

Meijuh commented Jul 26, 2021

@snicoll allright I can add it there np.

@Meijuh
Copy link
Contributor Author

Meijuh commented Jul 26, 2021

@snicoll the docs have been added.

@scottfrederick scottfrederick added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 29, 2021
@scottfrederick scottfrederick added this to the 2.6.x milestone Jul 29, 2021
@scottfrederick scottfrederick self-assigned this Aug 10, 2021
scottfrederick pushed a commit that referenced this pull request Aug 12, 2021
This commit adds configuration to the Maven and Gradle plugins to
allow specifying the network mode to be provided to the image
building goal and task.

See gh-27486
scottfrederick added a commit that referenced this pull request Aug 12, 2021
@scottfrederick
Copy link
Contributor

@Meijuh Thank you for the contribution. I've merged it along with a commit that polishes a few small items and adds integration tests for the new feature.

@scottfrederick scottfrederick modified the milestones: 2.6.x, 2.6.0-M2 Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add network option for image building

4 participants