Add resource labels to Stackdriver metrics configuration properties #26961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using resource labels is mandatory for most Stackdriver resources other than 'Global', i.e. k8s_pod. Configuring valid resource type along with related labels makes it possible to use given metric in a wider set of GCP solutions, i.e. custom metric based GKE pod horizontal autoscaler.
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
added
type: enhancement
wilkinsona
pushed a commit
that referenced
this pull request
Jul 13, 2021
Using resource labels is mandatory for most Stackdriver resources other than 'Global', i.e. k8s_pod. Configuring valid resource type along with related labels makes it possible to use given metric in a wider set of GCP solutions, i.e. custom metric based GKE pod horizontal autoscaler. See gh-26961
wilkinsona
added a commit
that referenced
this pull request
Jul 13, 2021
|
@mikouaj Thank you very much for making your first contribution to Spring Boot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using resource labels is mandatory for most Stackdriver resources other then
Global, i.e.k8s_pod.While setting resource type is supported in
StackdriverProperties, it is not possible to set labels in the same, configurable way.Configuring resource type only lead to issues as described in micrometer-metrics/micrometer#1907.
Using valid resource type along with required labels makes it possible to use given metric in a wider set of
GCP solutions, i.e. custom metric based GKE horizontal pod autoscaler.