Skip to content

Conversation

@onobc
Copy link
Contributor

@onobc onobc commented Feb 9, 2021

See #25130 for background.

@snicoll I went ahead and added the defaults test in this PR as I needed to update it to include the default and also use it to verify the changes.

If however, you want the 2.3.x changes to merge into here (purist tracking standpoint) just lmk and I will remove the test from this PR.

* process, just after a connection is opened.
*/
private Duration initQueryTimeout = Duration.ofMillis(500);
private Duration initQueryTimeout = Duration.ofSeconds(5);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* Idle timeout before an idle connection is removed.
*/
private Duration idleTimeout = Duration.ofSeconds(120);
private Duration idleTimeout = Duration.ofSeconds(5);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 9, 2021
@snicoll snicoll changed the title Aligns provided Cassandra defaults with the Cassandra driver's built-in defaults initQueryTimeout and ildeTimeout defaults are not aligned with Cassandra defaults Feb 10, 2021
@snicoll snicoll added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 10, 2021
@snicoll snicoll self-assigned this Feb 10, 2021
@snicoll snicoll added this to the 2.4.3 milestone Feb 10, 2021
@snicoll
Copy link
Member

snicoll commented Feb 10, 2021

I went ahead and added the defaults test in this PR as I needed to update it to include the default and also use it to verify the changes.

That's not what I was expecting. If testing the defaults and fixing the defaults are two separate PRs, including the former in the latter makes the separate PR completely irrelevant. I have reverted.

My understanding is that those two properties are tested in the 2.3.x version of the PR (and that passes because the values haven't been updated yet). By merging this PR ahead, we make sure the first PR you've raised can merge nicely.

@snicoll
Copy link
Member

snicoll commented Feb 10, 2021

Sigh. One of those two is also wrong in 2.3.x. I've created #25165

@onobc
Copy link
Contributor Author

onobc commented Feb 10, 2021

I went ahead and added the defaults test in this PR as I needed to update it to include the default and also use it to verify the changes.

That's not what I was expecting. If testing the defaults and fixing the defaults are two separate PRs, including the former in the latter makes the separate PR completely irrelevant. I have reverted.

My understanding is that those two properties are tested in the 2.3.x version of the PR (and that passes because the values haven't been updated yet). By merging this PR ahead, we make sure the first PR you've raised can merge nicely.

Sorry for the confusion @snicoll . It passed in 2.3 branch because the value changed in 4.8.1 (used by Boot 24) but was still 500ms in 4.6 driver (used by Boot 23).

In hindsight, had I figured that out sooner it would have probably made the most sense to do all of the work in 2.4 rather than 2.3 and partially here. Thanks for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants