Skip to content

Conversation

@dreis2211
Copy link
Contributor

Hi,

this PR fixes the configuration metadata for logging.charset.console and logging.charset.file by adjusting the wrong type information.

I only noticed in IDEA that no warning was shown when I entered a wrong charset encoding.
image
I guess other places consuming the metadata could be affected as well.

Cheers,
Christoph

@wilkinsona
Copy link
Member

Thanks, @dreis2211. I've opened #24852 to see if we can catch this sort of mistake automatically.

@snicoll snicoll self-assigned this Jan 17, 2021
@snicoll snicoll modified the milestones: 2.4.x, 2.4.3 Jan 17, 2021
@snicoll snicoll changed the title Fix configuration metadata for logging.charset.* properties Configuration metadata for logging.charset.* has invalid reference for java.nio.charset.Charset Jan 17, 2021
@snicoll snicoll closed this in f7c855d Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants