Skip to content

Conversation

@JimStockwell
Copy link
Contributor

The JavaDoc return description of ErrorAttributeOptions.getIncludes reads the same as isIncluded's return description.
This pull request corrects the description.

Return description was just incorrect,
maybe copied from the method above it?
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 26, 2020
@snicoll snicoll added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 26, 2020
@snicoll snicoll self-assigned this Nov 26, 2020
@snicoll snicoll added this to the 2.3.7 milestone Nov 26, 2020
@snicoll snicoll changed the title Correct getIncludes JavaDoc return description Invalid ErrorAttributesOptions#getInclude Javadoc Nov 26, 2020
snicoll pushed a commit that referenced this pull request Nov 26, 2020
@snicoll snicoll closed this in b4a1030 Nov 26, 2020
@snicoll
Copy link
Member

snicoll commented Nov 26, 2020

@JimStockwell good catch and thank you for making your first contribution to Spring Boot.

@JimStockwell JimStockwell deleted the fix-getIncludes-JavaDoc branch November 26, 2020 13:15
@JimStockwell
Copy link
Contributor Author

Thank you. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: documentation A documentation update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants