Skip to content

Provide a configuration property for the driverClassName of the Liquibase DataSource #23958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Provide a configuration property for the driverClassName of the Liquibase DataSource #23958

wants to merge 1 commit into from

Conversation

@evgeniycheban
Copy link
Contributor

Fixes gh-23810

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 29, 2020
@wilkinsona wilkinsona mentioned this pull request Oct 29, 2020
Closed
@wilkinsona wilkinsona self-assigned this Oct 29, 2020
@wilkinsona wilkinsona changed the title Add liquibase driver class name property Provide a configuration property for the driverClassName of the Liquibase DataSource Oct 29, 2020
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 29, 2020
@wilkinsona wilkinsona added this to the 2.4.0-RC1 milestone Oct 29, 2020
wilkinsona pushed a commit that referenced this pull request Oct 29, 2020
@evgeniycheban @wilkinsona
Add liquibase driver class name property
8a9b31a 
See gh-23958
wilkinsona added a commit that referenced this pull request Oct 29, 2020
@wilkinsona
Polish "Add liquibase driver class name property"
2db8e7e 
See gh-23958
@wilkinsona
Copy link
Member

wilkinsona commented Oct 29, 2020 •
edited
Loading

Thanks very much for the PR, @evgeniycheban. I've squeezed this into 2.4. While I was checking to see if an update to the documentation was needed, I was reminded that we fall back to the equivalent spring.datasource.* property for the Liquibase-specific url, username, and password properties so I've polished the proposal to do the same for driver-class-name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@wilkinsona wilkinsona

Labels

type: enhancement A general enhancement

Projects

None yet

Milestone

2.4.0-RC1

Development

Successfully merging this pull request may close these issues.

Add driverClassName Property to LiquibaseProperties.java

3 participants

@evgeniycheban @wilkinsona @spring-projects-issues