Skip to content

Support @Timed annotation for WebFlux #23112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Support @Timed annotation for WebFlux #23112

wants to merge 1 commit into from

Conversation

@anshlykov
Copy link
Contributor

Fixes #18680

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 27, 2020
imjmakki
imjmakki reviewed Sep 20, 2020
View reviewed changes
Copy link

@imjmakki imjmakki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

@philwebb philwebb added for: team-meeting An issue we'd like to discuss as a team to make progress type: enhancement A general enhancement and removed for: team-meeting An issue we'd like to discuss as a team to make progress status: waiting-for-triage An issue we've not yet triaged labels Dec 1, 2020
@philwebb philwebb added this to the 2.5.x milestone Dec 7, 2020
@philwebb philwebb requested a review from bclozel December 7, 2020 17:00
@patpatpat123

This comment has been minimized.

Sign in to view
@snicoll

This comment has been minimized.

Sign in to view
@philwebb philwebb self-assigned this Apr 9, 2021
@philwebb philwebb modified the milestones: 2.5.x, 2.5.0-RC1 Apr 9, 2021
philwebb pushed a commit that referenced this pull request Apr 9, 2021
@anshlykov @philwebb
Support @timed annotation for WebFlux
4ff4a9b 
Update `MetricsWebFilter` to support `@Timed` annotations on the WebFlux
handler methods or beans.

See gh-23112
philwebb added a commit that referenced this pull request Apr 9, 2021
@philwebb
Polish 'Support @timed annotation for WebFlux'
15fe418 
Extract common method logic to a `HandlerMethodTimedAnnotations`
utility class and also add some caching. Also move the test code
into a single class.

See gh-23112
@philwebb philwebb closed this in 78aa523 Apr 9, 2021
@philwebb
Copy link
Member

philwebb commented Apr 9, 2021

Thanks very much @anshlykov, this has now been merged to master and will be in Spring Boot 2.5

@philwebb philwebb added the status: noteworthy A noteworthy issue to call out in the release notes label Apr 9, 2021
@philwebb philwebb reopened this Apr 9, 2021
@philwebb
Copy link
Member

philwebb commented Apr 9, 2021

Reopening to update the docs at https://docs.spring.io/spring-boot/docs/current-SNAPSHOT/reference/htmlsingle/#production-ready-metrics-web-flux

@philwebb philwebb closed this in 7a636e5 Apr 9, 2021
@patpatpat123
Copy link

Many thanks all. good day!

philwebb added a commit that referenced this pull request Apr 10, 2021
@philwebb
Rework @Timer annotation support
9f16491 
Rework existing `@Timer` annotation support to remove duplicate code
and offer general purpose utilities that can be used in future metrics
support.

See gh-23112
See gh-22217
@izeye izeye mentioned this pull request Apr 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bclozel bclozel Awaiting requested review from bclozel

1 more reviewer

@imjmakki imjmakki imjmakki left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@philwebb philwebb

Labels

status: noteworthy A noteworthy issue to call out in the release notes type: enhancement A general enhancement

Projects

None yet

Milestone

2.5.0-RC1

Development

Successfully merging this pull request may close these issues.

Support @Timed annotation for WebFlux

6 participants

@anshlykov @patpatpat123 @snicoll @philwebb @imjmakki @spring-projects-issues