Fix unwrapping of captured PrintStream in test support's OutputCapture #22214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this should not be like this. I guess you made a mistake here. if you really get the original work flow, you should use `if` insteadof `while`.
XenoAmess
changed the title
XenoAmess
changed the title
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
changed the title
wilkinsona
added
type: task
wilkinsona
pushed a commit
that referenced
this pull request
Jul 7, 2020
wilkinsona
added a commit
that referenced
this pull request
Jul 7, 2020
|
Thanks very much, @XenoAmess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should not be like this. I guess you made a mistake here.
if you really get the original work flow, you should use
ifinsteadofwhile.Warning: this fix might be WRONG, so take good care about it.
If your original codes be a typo, and what I fix now is the function you want, that is OK.
But if the original codes works exactly what you want, then you should change
whiletoifeither of the two fixes should happen.