Simplify logic in ErrorPage's equals method #22082
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
requested changes
Jun 24, 2020
| ErrorPage other = (ErrorPage) obj; | ||
| boolean rtn = true; | ||
| rtn = rtn && ObjectUtils.nullSafeEquals(getExceptionName(), other.getExceptionName()); | ||
| rtn = ObjectUtils.nullSafeEquals(getExceptionName(), other.getExceptionName()); |
There was a problem hiding this comment.
Thanks for the suggestion. Rather than assigning rtn on 117 and then again on line 118, the two could be combined:
boolean rtn = ObjectUtils.nullSafeEquals(getExceptionName(), other.getExceptionName());
There was a problem hiding this comment.
@wilkinsona Thank you for your instruction. I have resubmitted it：
9d2793e
wilkinsona
changed the title
mbhave
added
type: task
mbhave
pushed a commit
that referenced
this pull request
Jun 30, 2020
|
@thenx-wei Thanks for making your first contribution to Spring Boot. This has now been merged into 2.2.x, 2.3.x and master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rtnvariables in classErrorPageis always true:boolean rtn = true;rtn = rtn && ObjectUtils.nullSafeEquals(getExceptionName(), other.getExceptionName());so it is reduced the following code:
boolean rtn = true;rtn = ObjectUtils.nullSafeEquals(getExceptionName(), other.getExceptionName());