Migrate NewRelic metrics to NewRelicClientProvider #20871
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0817e04.
Conflicts: spring-boot-project/spring-boot-dependencies/build.gradle
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
changed the title
|
Thanks for the PR. I prefer that we stick to configuring what Micrometer provides and only apply additional customizations if necessary. If a I've migrated our support in #20908 |
snicoll
added
status: declined
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #20839., this for the updates to support the new Micrometer NewRelicMeterRegistry changes introduced in 1.4.0, for the benefits noted in micrometer-metrics/micrometer#1647.
The registry now uses NewRelicClientProvider implementations to support two New Relic Insights integration options, that result in the same metrics published. The first, is the current REST API approach and a second that delegates to the New Relic APM Java Agent if present and not explicitly configured to use the REST API. If the Agent is not present, the API implementation will be implicitly configured.
@shakuzen