Skip to content

Fix typos #20704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dreis2211 wants to merge 1 commit into from
Closed

Fix typos #20704

dreis2211 wants to merge 1 commit into from

Conversation

@dreis2211
Copy link
Contributor

@dreis2211 dreis2211 commented Mar 27, 2020

Hi,

this PR fixes a couple of typos. I should note that the particular sentence in spring-boot-features still doesn't make a lot of sense to me even after the fix, but as I'm not a native speaker I wasn't sure if it might be correct.

Cheers,
Christoph

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 27, 2020
@snicoll
Copy link
Member

snicoll commented Mar 28, 2020

I should note that the particular sentence in spring-boot-features still doesn't make a lot of sense to me even after the fix

I wrote that and I agree the phrasing is a bit odd. I'll try to improve it as part of the polish.

snicoll
snicoll reviewed Mar 28, 2020
View reviewed changes
...main/java/org/springframework/boot/test/context/runner/AbstractApplicationContextRunner.java

/**
* Add a {@link ApplicationContextInitializer} to be
* calWebMvcEndpointChildContextConfigurationTestsled when the context is created.
Copy link
Member

@snicoll snicoll Mar 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh dear 🙈

Copy link
Contributor Author

@dreis2211 dreis2211 Mar 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked that one 🤣

@snicoll snicoll added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 28, 2020
@snicoll snicoll self-assigned this Mar 28, 2020
@snicoll snicoll added this to the 2.3.0.M4 milestone Mar 28, 2020
snicoll pushed a commit that referenced this pull request Mar 28, 2020
@dreis2211 @snicoll
Fix typos
674f1e7 
See gh-20704
@snicoll snicoll closed this in 85c9979 Mar 28, 2020
snicoll added a commit that referenced this pull request Mar 28, 2020
@snicoll
Polish
8154e67 
See gh-20704
@snicoll
Copy link
Member

snicoll commented Mar 28, 2020

Thanks again @dreis2211. I've polished that sentence in 8154e67. Let me know if that still reads odd.

@dreis2211
Copy link
Contributor Author

dreis2211 commented Mar 28, 2020

Isn't that a different sentence? You polished the one about DurationUnits and not DataSizeUnits. Nonetheless, it reads better ;-)

snicoll added a commit that referenced this pull request Mar 28, 2020
@snicoll
Polish
49ab5de 
See gh-20704
@snicoll
Copy link
Member

snicoll commented Mar 28, 2020

It is. Looks like that pattern was applied for DataSize as well. I've polished the other one in 49ab5de

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snicoll snicoll snicoll left review comments

Assignees

@snicoll snicoll

Labels

type: task A general task

Projects

None yet

Milestone

2.3.0.M4

Development

Successfully merging this pull request may close these issues.

3 participants

@dreis2211 @snicoll @spring-projects-issues