Improve error message when creating an image with no Docker Daemon available #20297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ker Daemon available. Translating IOException to DockerException for a more meaningful error message. formatting according to project formatting standards removing local change
spring-projects-issues
added
the
status: waiting-for-triage
… Rethrowing IOException as DockerException when executing an Http request and adding test to verify behavior.
snicoll
changed the title
scottfrederick
added a commit
to scottfrederick/spring-boot
that referenced
this pull request
Feb 27, 2020
scottfrederick
approved these changes
Feb 27, 2020
|
Merged via ce03f50 after squashing commits, editing the commit message in keeping with convention, and adding a few polishing changes. Including the entire stack trace in the translated exception made the output too verbose, so I reduced it to just the original exception message. Thanks @mikesmithson, and congratulations on your first contribution! |
snicoll
added
type: enhancement
snicoll
added
status: superseded
|
This should go in a milestone so that @mikesmithson is credited in the release notes. |
wilkinsona
added
type: enhancement
wilkinsona
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when creating an image with no Docker Daemon available. Translating IOException to DockerException for a more meaningful error message.
formatting according to project formatting standards
removing local change