Skip to content

Provide a configuration property for the maximum size of the in-memory buffer used by the reactive Elasticsearch REST client #20205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Provide a configuration property for the maximum size of the in-memory buffer used by the reactive Elasticsearch REST client #20205

wants to merge 1 commit into from

Conversation

@wonwoo
Copy link
Contributor

@wonwoo wonwoo commented Feb 16, 2020

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 16, 2020
@wilkinsona
Copy link
Member

wilkinsona commented Feb 18, 2020 •
edited
Loading

Thanks for the PR, @wonwoo. I think we may need to take a step back and consider if this is the right approach.

We already have a property, spring.codec.max-in-memory-size for configuring reactive codecs. Those used by the reactive Elasticsearch client fall into that category. I think we need to decide if we want the existing property to apply to the reactive Elasticsearch client or if we want to provide a separate property that is specific to reactive Elasticsearch. If we go with the latter option, we should probably review the description of the existing property to make its scope more clear.

@wilkinsona wilkinsona added the for: team-attention An issue we'd like other members of the team to review label Feb 18, 2020
@wilkinsona
Copy link
Member

We discussed this today and concluded that we should have separate properties as the limits should be separate. It may be reasonable for a request or response to Elasticsearch to be large while wanting HTTP request and responses to have a smaller limit.

@wilkinsona wilkinsona added for: merge-with-amendments Needs some changes when we merge type: enhancement A general enhancement and removed for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels Feb 26, 2020
@wilkinsona wilkinsona added this to the 2.3.x milestone Feb 26, 2020
@wilkinsona
Copy link
Member

As part of merging this, we should clarify the scope of spring.codec.max-in-memory-size.

@wilkinsona wilkinsona mentioned this pull request Mar 5, 2020
Closed
@wilkinsona wilkinsona changed the title webclient configuration of reactive elasticsearch Provide a configuration property for the maximum size of the in-memory buffer used by the reactive Elasticsearch REST client Mar 5, 2020
@bclozel bclozel self-assigned this Apr 2, 2020
@bclozel bclozel removed the for: merge-with-amendments Needs some changes when we merge label Apr 2, 2020
bclozel pushed a commit that referenced this pull request Apr 2, 2020
@wonwoo @bclozel
Configure codec buffer size in ES Reactive Rest client
a7e57e0 
This commit adds a new configuration property
`"spring.data.elasticsearch.client.reactive.max-in-memory-size"`
which configures the maximum amount of memory buffered by the
`WebClient` used by the Reactive ElasticSearch client.

See gh-20205
bclozel added a commit that referenced this pull request Apr 2, 2020
@bclozel
Polish
bbbf8c5 
See gh-20205
@bclozel bclozel closed this in 1199b7c Apr 2, 2020
@bclozel bclozel modified the milestones: 2.3.x, 2.3.0.M4 Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@bclozel bclozel

Labels

type: enhancement A general enhancement

Projects

None yet

Milestone

2.3.0.M4

Development

Successfully merging this pull request may close these issues.

4 participants

@wonwoo @wilkinsona @bclozel @spring-projects-issues