Use Dropwizard metrics BOM to manage dependencies #20032
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
pushed a commit
that referenced
this pull request
Feb 6, 2020
snicoll
added a commit
that referenced
this pull request
Feb 6, 2020
wilkinsona
added
type: task
Member
@dreis2211 I forgot to mention that I've polished the PR and downgraded as we prefer that dependency upgrades are done in an isolated commit with a dedicated issue so that users can find those more easily. I'll upgrade to |
Contributor
Author
|
Thanks for the update. I wasn't sure if that's okay - thanks for clarifying it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I just noticed that we could make use of Dropwizard's
metrics-bomto manage the dependencies. While doing so, I upgraded to 4.1.2 directly, because it adds dependency management formetrics-collectd.Let me know what you think.
Cheers,
Christoph