Skip to content

Add Stackdriver metrics export support #19528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add Stackdriver metrics export support #19528

wants to merge 1 commit into from

Conversation

@grafjo
Copy link
Contributor

@grafjo grafjo commented Jan 3, 2020

Add spring-boot-autoconfiguration support for Stackdriver via micrometer-registry-stackdriver

@pivotal-issuemaster
Copy link

@grafjo Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@grafjo Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 3, 2020
@grafjo grafjo force-pushed the autoconfigure-stackdriver-metrics branch from c7c8b19 to 9492a96 Compare January 3, 2020 22:17
@snicoll snicoll added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 7, 2020
@snicoll snicoll added this to the 2.3.x milestone Jan 7, 2020
@snicoll snicoll changed the title Add autoconfiguration support for Stackdriver metrics Add Stackdriver metrics export support Jan 7, 2020
@snicoll snicoll self-assigned this Jan 7, 2020
snicoll pushed a commit to snicoll/spring-boot that referenced this pull request Jan 7, 2020
@grafjo @snicoll
Add Stackdriver metrics export support
ccba876 
See spring-projectsgh-19528
snicoll added a commit to snicoll/spring-boot that referenced this pull request Jan 7, 2020
@snicoll
Polish "Add Stackdriver metrics export support"
41c07b7 
See spring-projectsgh-19528
@snicoll snicoll modified the milestones: 2.3.x, 2.3.0.M1 Jan 8, 2020
snicoll pushed a commit that referenced this pull request Jan 8, 2020
@grafjo @snicoll
Add Stackdriver metrics export support
d42256d 
See gh-19528
snicoll added a commit that referenced this pull request Jan 8, 2020
@snicoll
Polish "Add Stackdriver metrics export support"
462442e 
See gh-19528
@snicoll snicoll closed this in 91151e0 Jan 8, 2020
@snicoll
Copy link
Member

snicoll commented Jan 8, 2020

@grafjo thank you for making your first contribution to Spring Boot. I've polished your contribution to address code formatting and checkstyle violations for the most part. Please consider running the build locally next time as it would exhibit those issues and offer a way to reformat the code.

@dreis2211 dreis2211 mentioned this pull request Jan 8, 2020
Closed
@grafjo
Copy link
Contributor Author

grafjo commented Jan 8, 2020

@snicoll you're welcome! I'll do that next time - thx fot this hint.
I have one question regarding the documentation. Right now, there is no mention to create / provide a google service account to make the Stackdriver export working. Maybe a reference to the Micrometer documentation is usefull https://micrometer.io/docs/registry/stackdriver#_configuring - what do you think?

@snicoll
Copy link
Member

snicoll commented Jan 8, 2020

There is already a link to the micrometer doc in the section I added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@snicoll snicoll

Labels

type: enhancement A general enhancement

Projects

None yet

Milestone

2.3.0.M1

Development

Successfully merging this pull request may close these issues.

4 participants

@grafjo @pivotal-issuemaster @snicoll @spring-projects-issues