Skip to content

Add support for setting DirContextAuthenticationStrategy on the LdapContextSource #19328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add support for setting DirContextAuthenticationStrategy on the LdapContextSource #19328

wants to merge 1 commit into from

Conversation

@filiphr
Copy link
Contributor

@filiphr filiphr commented Dec 8, 2019 •
edited by philwebb
Loading

Set DirContextAuthenticationStrategy on the LdapContextSource
if there is a unique DirContextAuthenticationStrategy bean in the ApplicationContext

@filiphr
Add support for setting DirContextAuthenticationStrategy on the LdapC…
03c6f4c 
…ontextSource

Set DirContextAuthenticationStrategy on the LdapContextSource
if there is a unique DirContextAuthenticationStrategy bean in the ApplicationContext
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 8, 2019
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 8, 2019
@philwebb philwebb added this to the 2.3.x milestone Dec 8, 2019
@snicoll snicoll self-assigned this Dec 9, 2019
@snicoll snicoll modified the milestones: 2.3.x, 2.3.0.M1 Dec 9, 2019
snicoll pushed a commit that referenced this pull request Dec 9, 2019
@filiphr @snicoll
Detect DirContextAuthenticationStrategy bean
c108d2d 
This commit improves the LDAP auto-configuration to detect if a
DirContextAuthenticationStrategy bean is defined and, if so, associates
it with the auto-configured `LdapContextSource`.

See gh-19328
snicoll added a commit that referenced this pull request Dec 9, 2019
@snicoll
Polish "Detect DirContextAuthenticationStrategy bean"
aa82115 
See gh-19328
@snicoll snicoll closed this in e2a8017 Dec 9, 2019
@snicoll
Copy link
Member

snicoll commented Dec 9, 2019

Thanks @filiphr

@filiphr filiphr deleted the custom-dir-context-authentication-strategy branch December 9, 2019 15:06
@filiphr
Copy link
Contributor Author

filiphr commented Dec 9, 2019

No problem, thanks for merging it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@snicoll snicoll

Labels

type: enhancement A general enhancement

Projects

None yet

Milestone

2.3.0.M1

Development

Successfully merging this pull request may close these issues.

4 participants

@filiphr @snicoll @philwebb @spring-projects-issues