Handle ApiVersion in CachingOperationInvoker #18961
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, ApiVersion was treated as a mandatory parameter in CachingOperationInvokerAdvisor and thus prevented the CachingOperationInvoker to kick in. By skipping ApiVersion in the same way we're skipping SecurityContext we can avoid this. In order to not return the same cached response, this commit also changes the cache handling in CachingOperationInvoker to account for different ApiVersions being passed. Closes spring-projectsgh-18959
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
added
type: regression
|
Btw. I'm having trouble to see the concourse builds at the moment (it redirects me to a blank page). Might be related to the build-pipeline rename, but I thought I mention it at least ;-) |
|
Thanks, @dreis2211. Could you try again now please? |
|
Works like a charm, @wilkinsona . Thanks 👍 |
snicoll
pushed a commit
that referenced
this pull request
Nov 21, 2019
Prior to this commit, ApiVersion was treated as a mandatory parameter in CachingOperationInvokerAdvisor and thus prevented the CachingOperationInvoker to kick in. By skipping ApiVersion in the same way we're skipping SecurityContext we can avoid this. In order to not return the same cached response, this commit also changes the cache handling in CachingOperationInvoker to account for different ApiVersions being passed. See gh-18961
|
Thanks again Christoph! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this is a proposal for fixing #18959.
Prior to this commit,
ApiVersionwas treated as a mandatory parameter inCachingOperationInvokerAdvisorand thus prevented theCachingOperationInvokerto kick in. By skippingApiVersionin the same way we're skippingSecurityContextwe can avoid this.In order to not return the same cached response, this commit also changes the cache handling in
CachingOperationInvokerto account for differentApiVersions being passed.Let me know what you think.
Cheers,
Christoph