Let Liquibase smoke test pass on non-english systems #18873
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: task
snicoll
pushed a commit
that referenced
this pull request
Nov 22, 2019
This was referenced Nov 22, 2019
|
Thanks again Christoph. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed yesterday that the Liquibase smoke test failed on my machine. After having a quick look this is caused by a localized string that breaks the output assertion. On non-english systems it is therefore not possible to run the full smoke-test suite.
This PR simply sets
Locale.ENGLISHfor the test in question and resets it afterwards.I didn't feel comfortable with changing the assertion, because it covers the whole lifespan of the liquibase changelog process currently. Cutting it down to check less stuff didn't seem like the appropriate thing to do, but I'm happy to do it if you think that's favorable.
Cheers,
Christoph