Add auto-configuration for Spring Integration RSocket support #18834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#18812 To reuse RSocket server auto-configuration in Spring Integration, introduce an `IntegrationAutoConfiguration.IntegrationRSocketConfiguration` based on the `ServerRSocketMessageHandler` from Spring Integration which overrides an `RSocketMessagingAutoConfiguration` when SI is present on classpath. Configure a `ServerRSocketMessageHandler` from SI which is able to handle SI RSocket channel adapters and `@MessageMapping` if configured via new `IntegrationProperties.RSocket.Server.messageMappingEnabled`. Then add a `ServerRSocketConnector` which is based on the provided `ServerRSocketMessageHandler`. Also auto-configure a `ClientRSocketConnector` if `IntegrationProperties.RSocket.Client.port` or `IntegrationProperties.RSocket.Client.uri` configuration properties are present
artembilan
changed the title
|
Depends on spring-projects/spring-integration#3097 |
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
added
the
status: blocked
artembilan
changed the title
|
The upstream PR in SI has been merged, so this is ready for review and feedback. While I'm here I have realized that such an integration test I have here with an explicit port for RSocket server could be is not what you would like to see in the auto-configuration module. Let me know how to proceed! Also: do you need some docs on the matter? Thanks |
bclozel
removed
the
status: blocked
philwebb
added
the
for: team-attention
philwebb
changed the title
philwebb
added
status: pending-design-work
Spring integration RSocket support if there is no any Spring Integration RSocket channel adapters * Change `IntegrationAutoConfigurationTests.rsocketSupportEnabled()` to check auto-configured beans instead of integration testing
|
Let's look at this for 2.3.0.M2. |
bclozel
removed
the
status: pending-design-work
bclozel
added a commit
that referenced
this pull request
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18812
To reuse RSocket server auto-configuration in Spring Integration,
introduce an
IntegrationAutoConfiguration.IntegrationRSocketConfigurationbased on the
ServerRSocketMessageHandlerfrom Spring Integration whichoverrides an
RSocketMessagingAutoConfigurationwhen SI is present onclasspath.
Configure a
ServerRSocketMessageHandlerfrom SI which is able to handleSI RSocket channel adapters and
@MessageMappingif configured vianew
IntegrationProperties.RSocket.Server.messageMappingEnabled.Then add a
ServerRSocketConnectorwhich is based on the providedServerRSocketMessageHandler.Also auto-configure a
ClientRSocketConnectorifIntegrationProperties.RSocket.Client.portorIntegrationProperties.RSocket.Client.uriconfiguration properties arepresent