Make optimizedLaunch property name more consistent #18702
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename maven spring boot plugin optimizedLaunch property to spring-boot.run.optimizedLaunch to make it more consistent with the other spring-boot:run goal
spring-projects-issues
added
the
status: waiting-for-triage
|
Good catch @AlexFalappa, thanks! And bummer. I am tempted to fix this in |
snicoll
added
the
for: team-attention
|
@snicoll yeah I realised that myself, that's a bit unfortunate. I would be in favour of renaming it now rather than later cause I think not many users will be affected and tooling has yet to catch up. If 2.2.1 is planned shortly no one will notice 😄. The fact that it is enabled by default helps because turning it off is less frequently needed. |
snicoll
added
type: bug
snicoll
pushed a commit
that referenced
this pull request
Oct 23, 2019
|
We've discussed this and agree with you @AlexFalappa. Thanks again for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename maven spring boot plugin
optimizedLaunchproperty tospring-boot.run.optimizedLaunchto make it more consistent with the other spring-boot:run goal property names.