Use LinkedHashSet for deterministic order in test assertion #18612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
This comment has been minimized.
This comment has been minimized.
wilkinsona
added
type: task
snicoll
changed the title
snicoll
pushed a commit
that referenced
this pull request
Oct 16, 2019
Member
|
@contextshuffling thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test case
testSerializationis trying to test the serialization of CompositeHealthIndicator. However, there is a subtle dependency that the serialization depends on, which is the iteration order of HashMap it uses. However, HashMap does not guarantee any specific order of entries. Therefore, the assertions will fail if the order is different.Test cases should pass regardless of the HashMap iteration orders, otherwise it cannot serve as a regression test.
This PR proposes to change HashMap to use LinkedHashMap that makes the iteration order deterministic, which is the insertion order. The test also assumes this order so no need to modify the test assertion.