Support new Micrometer NewRelicConfig eventType properties #18472
Conversation
New categorical eventType to publish New Relic metrics and meterNameEventTypeEnabled (true) for compatibility with previous behavior of publishing an eventType per Meter/metric name. NewRelic's own agents publish metrics to eventTypes aligned with broader categories. To align with their recommendation the default behavior is to publish metrics under a "SpringBootSample" category. When doing so, additional context is provided by including "metricName" and "metricType" attributes. See: https://docs.newrelic.com/docs/insights/insights-data-sources/default-data/insights-default-data-other-new-relic-products
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
changed the title
…ot.git into Add-Support-Micrometer-New-Relic-Config
|
Build failures appear to be issues unrelated to this PR. After merging in master, error is now from the Spring Boot Docs project: |
|
Confirmed. Sorry for the inconvenience. The problem should be fixed in master now. Don't worry about the build failure as the changes proposed here are built before the docs module where the problem is occurring. |
|
Just for reference, micrometer-metrics/micrometer#1588 is the pull request that added these config properties to Micrometer 1.3. Once these changes are made in Spring Boot, feel free to also send a pull request to Micrometer's |
wilkinsona
added
type: enhancement
|
@wilkinsona Thanks for the quick confirmation and note. I'll still try another rebase from master to see if it will build cleanly. @shakuzen Thanks for the review and reference to the initiating PR. I'll be happy to get the legacy project updated. |
New categorical eventType to publish New Relic metrics and meterNameEventTypeEnabled (true) for compatibility with previous behavior of publishing an eventType per Meter/metric name. NewRelic's own agents publish metrics to eventTypes aligned with broader categories. To align with their recommendation the default behavior is to publish metrics under a "SpringBootSample" category. When doing so, additional context is provided by including "metricName" and "metricType" attributes. See: https://docs.newrelic.com/docs/insights/insights-data-sources/default-data/insights-default-data-other-new-relic-products
…hub.com/neiljpowell/spring-boot.git into Add-Support-Micrometer-New-Relic-Config
…ot.git into Add-Support-Micrometer-New-Relic-Config
philwebb
changed the title
Update `NewRelicProperties` so that the event type sent with each metric can be configured. An additional `boolean` property has also been added if the previous behavior using the "meter-name" is required. NewRelic's own agents publish metrics to eventTypes aligned with broader categories. To align with their recommendation the default behavior is to publish metrics under a "SpringBootSample" category. When doing so, additional context is provided by including "metricName" and "metricType" attributes. See gh-18472
|
Thanks very much for the PR @neiljpowell. This has now been merged to master and should be in RC1. |
5 participants
New categorical
eventTypeto publish New Relic metrics andmeterNameEventTypeEnabled(true)for compatibility with previousbehavior of publishing an
eventTypeper Meter/metric name.NewRelic's own agents publish metrics to
eventTypesaligned with broadercategories. To align with their recommendation the default behavior is
to publish metrics under a "SpringBootSample" category. When doing so,
additional context is provided by including "metricName" and "metricType" attributes.
See: https://docs.newrelic.com/docs/insights/insights-data-sources/default-data/insights-default-data-other-new-relic-products
@shakuzen
@breedx-nr