Fix escaping of pipe character in reference tables #18374
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
while working on #18371 I noticed that there are some issues with the handling of
|inside tables in the reference docs. Here's a list of issues that I found, but there might be more:server.tomcat.internal-proxiesshows{vbar}in both HTML and PDF reference instead of|server.tomcat.relaxed-path-charsbreaks the table formatting completely in the PDF versionserver.tomcat.relaxed-query-charsbreaks the table yet another time ;-)It seems that neither of the escaping strategies work for both HTML and PDF. Luckily, the docs under https://asciidoctor.org/docs/user-manual/#escaping-the-cell-separator provide a third option.
Applying this seems to fix the issues mentioned above.
Let me know what you think.
Cheers,
Christoph