Add property ROLLING_FILE_LOG_PATTERN for File Appender #18151
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jorgheymans
reviewed
Sep 6, 2019
...ct/spring-boot/src/main/resources/org/springframework/boot/logging/logback/file-appender.xml
Outdated
Show resolved
Hide resolved
|
Should this also be added in the documentation somewhere ? (https://docs.spring.io/spring-boot/docs/current/reference/html/howto-logging.html) |
eddumelendez
force-pushed
the
gh-18140
branch
from
3efb11b to
2b9006f
Compare
|
PR has been updated. Thanks @jorgheymans and @wilkinsona |
eddumelendez
changed the title
eddumelendez
force-pushed
the
gh-18140
branch
from
2b9006f to
35f3074
Compare
philwebb
added
type: enhancement
|
I am wondering if the property shouldn't be Rather than |
snicoll
added
the
for: team-attention
philwebb
added
for: merge-with-amendments
|
@snicoll should I apply the changes suggested? |
|
If you have time shortly, feel free to do it. I intended to polish your PR sometime Monday. Either is fine, thanks for asking! |
This new property allows to customize `fileNamePattern` if it is set. Otherwise, a default pattern remains. Also, new property is supported `logging.pattern.rolling-file`. See spring-projectsgh-18140
eddumelendez
force-pushed
the
gh-18140
branch
from
35f3074 to
66e185b
Compare
snicoll
pushed a commit
that referenced
this pull request
Sep 16, 2019
This new property allows to customize `fileNamePattern` if it is set. Otherwise, a default pattern remains. Also, new property is supported `logging.pattern.rolling-file-name`. See gh-18151
snicoll
added a commit
that referenced
this pull request
Sep 16, 2019
|
Thanks @eddumelendez |
pull bot
pushed a commit
to scope-demo/spring-boot
that referenced
this pull request
Sep 16, 2019
This new property allows to customize `fileNamePattern` if it is set. Otherwise, a default pattern remains. Also, new property is supported `logging.pattern.rolling-file-name`. See spring-projectsgh-18151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new property allows to customize
fileNamePatternif it is set.Otherwise, a default pattern remains. Also, new property is supported
logging.pattern.rolling-file.See gh-18140