Simplify SslContextFactory usage when configuring JettyClientHttpConnector #17015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: task
|
@philwebb can you please rerun CI build? It is pending since yesterday |
|
@ielatif I'm afraid our CI system is under maintenance at the moment. Hopefully it should be back today. |
|
@philwebb thanks for sharing |
…ector This commit simplify SslContextFactory usage when configuring JettyClientHttpConnector since it provides a constructor that takes a HttpClient and a JettyResourceFactory as parameters. Closes spring-projectsgh-16994
|
@philwebb I got CI to work. |
|
Thanks very much, this has now been merged to |
philwebb
pushed a commit
that referenced
this pull request
May 31, 2019
Simplify `ClientHttpConnectorConfiguration`by using the recently introduced `JettyClientHttpConnector` constructor. See gh-17015
|
Fixed in 4ac1407. I accidentally rebased and lost the merge commit. |
wilkinsona
pushed a commit
to wilkinsona/spring-boot
that referenced
this pull request
Jun 4, 2019
Simplify `ClientHttpConnectorConfiguration`by using the recently introduced `JettyClientHttpConnector` constructor. See spring-projectsgh-17015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit simplify SslContextFactory usage when configuring JettyClientHttpConnector since it provides a constructor that takes a HttpClient and a JettyResourceFactory as parameters.
Closes gh-16994