Fix compilation error #16476
Closed
Fix compilation error #16476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
Test failure could be related, but I have the weird feeling this might be related to #16410 . |
|
Me too even though we had green builds after this was merged. Nothing jumps at me that might have changed in framework in the meantime. Paging @sdeleuze. |
snicoll
added
type: task
snicoll
added a commit
that referenced
this pull request
Apr 6, 2019
* pr/16476: Fix compilation error
|
@dreis2211 I might have fixed it in 84735f5 - We've harmonized the context hierarchy recently and those tests were calling refresh twice (which is not something the regular hierarchy allows). Arguably, that was a problem in the test in the first place so I've moved them to use the |
|
@snicoll Thanks for the heads up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR fixes a compilation error caused by a missing implementation in
AbstractWebFluxEndpointHandlerMappingofSet<PathPattern> getMappingPathPatterns(RequestMappingInfo mapping)that seems to have been introduced recently.Cheers,
Christoph