Polish embedded tomcat setup #16446
Closed
Polish embedded tomcat setup #16446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 3, 2019 20:28
…ass or in any tests. Might have been copied from TomcatServletWebServerFactory which is referenced in tests
spring-projects-issues
added
the
status: waiting-for-triage
mbhave
reviewed
Apr 3, 2019
| * The class name of default protocol used. | ||
| */ | ||
| public static final String DEFAULT_PROTOCOL = "org.apache.coyote.http11.Http11NioProtocol"; | ||
| private static final String DEFAULT_PROTOCOL = "org.apache.coyote.http11.Http11NioProtocol"; |
There was a problem hiding this comment.
I don't think we can make this private in case someone else is relying on it.
There was a problem hiding this comment.
You're right, sorry. I was thinking like someone working on their own final codebase as opposed to one that's used by others as a library :)
added 2 commits
April 4, 2019 19:39
|
Reverted the change |
philwebb
added
type: task
snicoll
changed the title
snicoll
pushed a commit
that referenced
this pull request
Apr 5, 2019
snicoll
added a commit
that referenced
this pull request
Apr 5, 2019
* pr/16446: Polish "Polish embedded tomcat setup" Polish embedded tomcat setup
|
@za-rudeboy thank you for making your first contribution to Spring Boot. Your contribution is now merged on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small code cleanups such as removing a redundant class cast, null check and making fields final that can be final