Include health details in the Elasticsearch REST and Jest HealthIndicators #15366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
filiphr
commented
Dec 2, 2018
filiphr
commented
- When response status code is not 200 include the actual status code and the reason phrase
- When response status code is 200 then include the entire response map as details for the health
* When response status code is not 200 include the actual status code and the reason phrase * When response status code is 200 then include the entire response map as details for the health
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: enhancement
bclozel
changed the title
bclozel
pushed a commit
that referenced
this pull request
Dec 11, 2018
This commit adds more information to the ElasticSearch REST health indicator. When the ES instance responds with an error HTTP status, the health details now include the actual status code and reason phrase. When the ES instance returns a HTTP 200 response, the entire response map is used as health details. See gh-15366
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.