Fail fast if nested condition uses a phase inappropriate for its members #15086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
4 tasks
philwebb
added
type: enhancement
snicoll
removed
the
status: first-timers-only
snicoll
approved these changes
Dec 3, 2018
snicoll
pushed a commit
that referenced
this pull request
Dec 3, 2018
snicoll
added a commit
that referenced
this pull request
Dec 3, 2018
* pr/15086: Polish contribution Fail fast if nested condition uses a phase inappropriate for its members
|
@onraz thank you very much for making your first contribution to Spring Boot. This is now merged with a polish commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses gh-10347 by ensuring a nested condition doesn't use a
PARSE_CONFIGURATIONphase when any member conditions have aREGISTER_BEANphase. This contract is enforced inAbstractNestedCondition, such that all subclasses (e.g.AllNestedCondition) also enforce it. The change is applied as the conditions are loaded with single pass, to minimize performance overhead.