Skip to content

Conversation

@up-to-you
Copy link

Fix stack-trace line break inside div for DefaultErrorWebExceptionHandler

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 2, 2018
@pivotal-issuemaster
Copy link

@up-to-you Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@bclozel bclozel self-assigned this Nov 6, 2018
@bclozel bclozel added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 6, 2018
@bclozel bclozel added this to the 2.1.1 milestone Nov 6, 2018
@bclozel bclozel changed the title Fix stack-trace line break inside div Fix stack-trace line breaks in whitelabel error views Nov 6, 2018
@bclozel bclozel closed this in 026d9ac Nov 6, 2018
@bclozel bclozel reopened this Nov 6, 2018
@bclozel
Copy link
Member

bclozel commented Nov 6, 2018

@up-to-you Could you sign the CLA so that I can merge your pull-request please?

@pivotal-issuemaster
Copy link

@up-to-you Thank you for signing the Contributor License Agreement!

@up-to-you
Copy link
Author

Everything, regarding to CLA signing is done , i hope.

@snicoll
Copy link
Member

snicoll commented Nov 7, 2018

@up-to-you indeed, thank you.

@snicoll snicoll closed this Nov 7, 2018
@wilkinsona
Copy link
Member

This still needs to be merged. Brian backed it out when he realised the CLA had not be signed.

@wilkinsona wilkinsona reopened this Nov 7, 2018
@bclozel bclozel closed this in 159f947 Nov 7, 2018
@bclozel
Copy link
Member

bclozel commented Nov 7, 2018

Thanks for your first contribution @up-to-you !

@wilkinsona
Copy link
Member

This change has broken the build as two tests were not expecting the style attribute to appear in the <div>.

@wilkinsona wilkinsona reopened this Nov 8, 2018
@wilkinsona wilkinsona self-assigned this Nov 8, 2018
@wilkinsona wilkinsona closed this in e7d921c Nov 8, 2018
@wilkinsona wilkinsona added type: bug A general bug and removed type: enhancement A general enhancement labels Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants