Skip to content

Align max HTTP header size configuration across all supported containers #14234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Align max HTTP header size configuration across all supported containers #14234

wants to merge 3 commits into from

Conversation

@qct
Copy link
Contributor

@qct qct commented Aug 29, 2018

Align max HTTP header size configuration across all supported containers

Fix: #13831

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 29, 2018
snicoll
snicoll reviewed Aug 29, 2018
View reviewed changes
Copy link
Member

@snicoll snicoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I've added a couple of suggestions.

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Aug 29, 2018
@snicoll snicoll mentioned this pull request Aug 29, 2018
Closed
@snicoll snicoll mentioned this pull request Aug 31, 2018
Closed
@snicoll snicoll changed the title Set default maxHttpHeaderSize to 8192 bytes, fix Netty and Jetty behavior Align max HTTP header size configuration across all supported containers Aug 31, 2018
@snicoll snicoll self-assigned this Aug 31, 2018
@snicoll snicoll added type: enhancement A general enhancement and removed status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged labels Aug 31, 2018
@snicoll snicoll modified the milestones: Backlog, 2.1.0.M3 Aug 31, 2018
snicoll pushed a commit that referenced this pull request Sep 4, 2018
@qct @snicoll
Align max HTTP header size configuration
dbbb378 
See gh-14234
@snicoll snicoll closed this in 8771b34 Sep 4, 2018
snicoll added a commit that referenced this pull request Sep 4, 2018
@snicoll
Merge pull request #14234 from qct:max-header
9496e87 
* pr/14234:
  Polish "Align max HTTP header size configuration"
  Align max HTTP header size configuration
@snicoll
Copy link
Member

snicoll commented Sep 4, 2018

Thanks @qct, this is now merged with a polish commit

@qct qct deleted the max-header branch September 11, 2018 01:18
@snicoll snicoll mentioned this pull request Oct 28, 2018
Closed
@Na3blis
Copy link

Na3blis commented May 9, 2019 •
edited
Loading

@snicoll This should definitely be added to the changelog/release notes! We just spent 3 weeks tracking down random 400 errors we were receiving. We tracked it down to upgrading from Spring Boot 2.0 to 2.1, but after combing through the changelogs we didn't see anything that would cause our problems. Finally we came across this, and figured out the issue, since we use Undertow.

@wilkinsona
Copy link
Member

Sorry for the trouble, @Na3blis, and thanks for taking the time to make us aware of the problem caused. I've added an entry to the release notes for 2.1 so that others hopefully have an easier time of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snicoll snicoll snicoll left review comments

Assignees

@snicoll snicoll

Labels

type: enhancement A general enhancement

Projects

None yet

Milestone

2.1.0.M3

Development

Successfully merging this pull request may close these issues.

Align max HTTP header size configuration across all supported containers

5 participants

@qct @snicoll @Na3blis @wilkinsona @spring-projects-issues