Support transaction manager, error handler and after rollback processor with Kafka #14215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
garyrussell
commented
Aug 27, 2018
garyrussell
commented
- transaction manager
- error handler
- after rollback processor
- transaction manager - error handler - after rollback processor
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: enhancement
snicoll
reviewed
Aug 28, 2018
| automatically associated to the default factory. | ||
| `spring.kafka.listener.*`. | ||
| If the property `spring.kafka.producer.transaction-id-prefix` is defined, a | ||
| `KafkaTransactionManager` will be auto-configured with name `kafkaTransactionManager` and |
There was a problem hiding this comment.
Where is the behaviour implemented? All I can see here is that a TransactionManager is associated if it exists. Is @EnableKafka doing that for us? Is that a PlatformTransactionManager (in which case we need to be careful about conflicts).
There was a problem hiding this comment.
A TM is already autoconfigured in KafkaAutoConfiguration, but I guess it was never documented (looks like a community contribution).
@Bean
@ConditionalOnProperty(name = "spring.kafka.producer.transaction-id-prefix")
@ConditionalOnMissingBean
public KafkaTransactionManager<?, ?> kafkaTransactionManager(
ProducerFactory<?, ?> producerFactory) {
return new KafkaTransactionManager<>(producerFactory);
}(I wasn't aware of it either - it threw me a bit when I got weird results).
| instance. | ||
| When using a `ChainedKafkaTransactionManager`, it will usually reference the configured | ||
| `KafkaTransactionManager` bean, so the chained manager must be marked | ||
| `@Primary` if you want it wired into the container factory. |
There was a problem hiding this comment.
I didn't understand that note (probably related to the fact I am confused per my other comment).
snicoll
added
the
status: waiting-for-feedback
snicoll
changed the title
snicoll
removed
the
status: waiting-for-feedback
snicoll
pushed a commit
that referenced
this pull request
Aug 28, 2018
- transaction manager - error handler - after rollback processor See gh-14215
snicoll
added a commit
that referenced
this pull request
Aug 28, 2018
* pr/14215: Polish "Improve Kafka Auto-configuration" Improve Kafka Auto-configuration
|
Thanks @garyrussell, this is now merged in |
philwebb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.