Update MongoAutoConfiguration and MongoDataAutoConfiguration to support com.mongodb.client.MongoClient. #14176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
christophstrobl
force-pushed
the
issue/datamongo_autoconfig_for_com.mongodb.client.Client
branch
from
65bea5d to
9d763f5
Compare
snicoll
reviewed
Aug 23, 2018
| @Retention(RetentionPolicy.RUNTIME) | ||
| @Documented | ||
| @Conditional(OnBeanCondition.class) | ||
| public @interface ConditionalOnAnyBean { |
There was a problem hiding this comment.
We have AnyNestedCondition for that. Have you considered using that instead?
I am not keen to expose yet another top level annotations for this feature if we can avoid it.
| mongoTemplate.getConverter()); | ||
| } | ||
|
|
||
| @Nullable |
There was a problem hiding this comment.
We don't use @Nullable in the code base (yet).
| private <T> T mongoClientOrNull(Class<T> mongoClientType) { | ||
|
|
||
| try { | ||
| return this.beanFactory.getBean(mongoClientType); |
There was a problem hiding this comment.
Rather than doing that, could you please inject an ObjectProvider and use its API. That would prevent from calling the BeanFactory directly.
snicoll
added
the
status: waiting-for-feedback
|
thanks @snicoll will modify the PR according to your input. |
…rt com.mongodb.client.MongoClient. Next to com.mongodb.MongoClient the MongoDB Java driver offers the com.mongodb.client.MongoClient as entry point for database and collection operations. Spring Data MongoDB supports c.m.client.MongoClient via its MongoDbFactory using SimpleMongoClientDbFactory. The MongoAutoConfiguration now backs off if any of those two clients is already defined in the Application context allowing MongoDataAutoConfiguration to pick up the users driver implementation of choice.
christophstrobl
force-pushed
the
issue/datamongo_autoconfig_for_com.mongodb.client.Client
branch
from
9d763f5 to
ba16e58
Compare
|
@snicoll changes are in. |
philwebb
added
type: enhancement
snicoll
pushed a commit
that referenced
this pull request
Aug 28, 2018
Next to com.mongodb.MongoClient the MongoDB Java driver offers the com.mongodb.client.MongoClient as entry point for database and collection operations. Spring Data MongoDB supports c.m.client.MongoClient via its MongoDbFactory using SimpleMongoClientDbFactory. The MongoAutoConfiguration now backs off if any of those two clients is already defined in the Application context allowing MongoDataAutoConfiguration to pick up the users driver implementation of choice. See gh-14176
snicoll
added a commit
that referenced
this pull request
Aug 28, 2018
* pr/14176: Polish "Add support for com.mongodb.client.MongoClient" Add support for com.mongodb.client.MongoClient
|
Thanks Christoph, this is now merged with a polish commit (see 56329e6) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next to
com.mongodb.MongoClientthe MongoDB Java drivers offers thecom.mongodb.client.MongoClientas entry point for database and collection operations. Spring Data MongoDB supportsc.m.client.MongoClientvia itsMongoDbFactoryusingSimpleMongoClientDbFactory.The
MongoAutoConfigurationnow backs off if any of those two clients is already defined in theApplicationContextallowingMongoDataAutoConfigurationto pick up the users driver implementation of choice.