Polish #14172
Closed
Polish #14172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
reviewed
Aug 23, 2018
| @Override | ||
| public void onApplicationEvent(ApplicationEvent event) { | ||
| if (event instanceof ContextRefreshedEvent) { | ||
| if (event instanceof ContextRefreshedEvent |
Member
There was a problem hiding this comment.
Can we keep the two ifs please? (and combine the two conditions for the second if). It reads better IMO
Contributor
Author
There was a problem hiding this comment.
@snicoll I thought that the two if statements doing the same thing are unusual as it looks to me as follows:
if (condition1) {
doSomething();
}
if (condition2) {
doSomething();
}
WDYT? If you still prefer as-is, please let me know. Then I'll revert it.
Member
There was a problem hiding this comment.
Thanks for the feedback. There are but the proposal condition is a big fat IMO. I am not really leaning one way or the other actually, let me checkout the code in an IDE.
snicoll
approved these changes
Aug 23, 2018
snicoll
added
type: task
Member
|
Thanks again @izeye! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some typos and polishes trivial stuff.