Fix deprecation in UndertowServletWebServerFactory #13873
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Member
|
@dreis2211 that is correct, that's my next task once I am done with the PR I am reviewing. |
Member
|
It's a shame |
Contributor
Author
|
Isn't Spring-Boot 2.x on |
Member
|
No, it isn't. Only |
Contributor
Author
|
Ah, fair enough. Should we wait then? |
Member
|
I don't know. |
snicoll
added
for: team-attention
snicoll
added
type: task
snicoll
approved these changes
Jul 25, 2018
snicoll
added a commit
that referenced
this pull request
Jul 25, 2018
* pr/13873: Fix deprecation in UndertowServletWebServerFactory
Member
|
I've decided to go with this one and I've created a separate issue to remind us to fix the method when we upgrade to |
Contributor
Author
|
Highly appreciated - as always, @snicoll |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR fixes a deprecation in
UndertowServletWebServerFactory.Cheers,
Christoph
P.S.: I'm currently having test failures in
NoSuchBeanDefinitionFailureAnalyzerTeststhat seem unrelated.