Allow LocalHostUriTemplateHandler to be created with a custom underlying UriTemplateHandler #13208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing UriTemplateHandler
snicoll
requested changes
May 18, 2018
| private final String rootUri; | ||
|
|
||
| private final UriTemplateHandler handler; | ||
| private final UriTemplateHandler delegateHandler; |
There was a problem hiding this comment.
This rename sounds unnecessary for the task at hand. Can you please revert?
| * @param environment the environment used to determine the port | ||
| * @param scheme the scheme of the root uri | ||
| * @param delegateHandler the delegate handler | ||
| * @since 2.0.X |
There was a problem hiding this comment.
since tag uses actual version. That would be 2.0.3.
snicoll
added
the
status: waiting-for-feedback
|
@mihhail-lapushkin thanks for the quick feedback. I did edit my comment to mention the addition of a test. Thoughts? |
|
Sure, I can add some. |
snicoll
added
type: enhancement
snicoll
approved these changes
May 18, 2018
snicoll
pushed a commit
that referenced
this pull request
May 18, 2018
snicoll
added a commit
that referenced
this pull request
May 18, 2018
* pr/13208: Polish contribution Support custom UriTemplateHandler in LocalHostUriTemplateHandler
|
@mihhail-lapushkin thanks for the PR, it is now merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12871