Skip to content

Add a missing '=' condition to RandomAccessDataFile.read() #12984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add a missing '=' condition to RandomAccessDataFile.read() #12984

wants to merge 1 commit into from

Conversation

@izeye
Copy link
Contributor

@izeye izeye commented Apr 27, 2018

This PR adds an = condition to RandomAccessDataFile.read() as it looks missed.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 27, 2018
@wilkinsona wilkinsona mentioned this pull request Apr 27, 2018
Closed
@wilkinsona
Copy link
Member

Thanks, @izeye. Reviewing this has made me realise that we need to specify the behaviour of RandomAccessData.read(long, long) more precisely. I've opened #12986. I'm going to close this PR as I suspect that we'll end up doing something different to the change that's proposed here.

@wilkinsona wilkinsona closed this Apr 27, 2018
@wilkinsona wilkinsona removed the status: waiting-for-triage An issue we've not yet triaged label Apr 27, 2018
@izeye izeye deleted the add-equals branch April 27, 2018 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@izeye @wilkinsona @spring-projects-issues