Remove HierarchicalNameMapper as a configured @Bean #12683
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HierarchicalNameMapper is not a component that can be shared amongst multiple monitoring systems.
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks @jkschneider, this is what I had in mind. It's a breaking change in the sense that a custom Given that doing that is wrong, I am in favour of merging this. Let's see what the rest of the team thinks. |
snicoll
added
the
for: team-attention
This was referenced Mar 29, 2018
|
I think we should merge this, probably better to make a small breaking change than limp on with a bad assumption. |
philwebb
added
type: bug
snicoll
removed
the
for: team-attention
snicoll
approved these changes
Apr 3, 2018
snicoll
pushed a commit
that referenced
this pull request
Apr 3, 2018
HierarchicalNameMapper is not a component that can be shared amongst multiple monitoring systems. See gh-12683
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed solution for #12676.