Skip to content

Remove destroy methods on MeterRegistry autoconfigs #12121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove destroy methods on MeterRegistry autoconfigs #12121

wants to merge 1 commit into from

Conversation

@jkschneider
Copy link
Contributor

@jkschneider jkschneider commented Feb 19, 2018 •
edited
Loading

MeterRegistry is now AutoCloseable, and stop methods are called when necessary.

Additionally, PauseDetector threads are cleaned up.

LogbackMetrics removes its TurboFilter from LoggerContext on close as well.

See micrometer-metrics/micrometer#438

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 19, 2018
@wilkinsona wilkinsona self-assigned this Feb 19, 2018
@wilkinsona wilkinsona added type: task A general task priority: normal and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 19, 2018
@wilkinsona wilkinsona added this to the 2.0.0.RC2 milestone Feb 19, 2018
wilkinsona added a commit that referenced this pull request Feb 19, 2018
@wilkinsona
Merge pull request #12121 from Jon Schneider
d98eafb 
* gh-12121:
  Remove destroy methods from auto-configured MeterRegistry beans
@mbhave mbhave mentioned this pull request Jan 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@wilkinsona wilkinsona

Labels

type: task A general task

Projects

None yet

Milestone

2.0.0.RC2

Development

Successfully merging this pull request may close these issues.

3 participants

@jkschneider @wilkinsona @spring-projects-issues