Restore behavior of management.metrics.export.simple.enabled #12106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkschneider
commented
Feb 18, 2018
| } | ||
|
|
||
| @Override | ||
| public boolean enabled() { |
There was a problem hiding this comment.
Having this property at all in SimpleConfig was a mistake. When this is merged, I'll remove it.
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
reviewed
Feb 19, 2018
| * Enable in-memory metrics that aren't published anywhere (allows you to see | ||
| * what metrics are collected in the metrics actuator endpoint). | ||
| */ | ||
| private boolean enabled; |
There was a problem hiding this comment.
The default value here should be true. And we shouldn't have a property at all since it's not used anywhere in the code.
There was a problem hiding this comment.
Yep, I guess adding it to additional-spring-configuration-metadata.json accomplishes the same.
| /** | ||
| * Enable publishing to the backend. | ||
| * Enable in-memory metrics that aren't published anywhere (allows you to see | ||
| * what metrics are collected in the metrics actuator endpoint). |
There was a problem hiding this comment.
I think that's a bit misleading and we should rephrase that.
snicoll
added
type: enhancement
snicoll
pushed a commit
that referenced
this pull request
Feb 19, 2018
snicoll
added a commit
that referenced
this pull request
Feb 19, 2018
* pr/12106: Polish "Restore behavior of management.metrics.export.simple.enabled" Restore behavior of management.metrics.export.simple.enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point when all the individual implementation configurations were changed to auto-configurations in Boot 2, the conditionalization of the config based on
managament.metrics.export.simple.enabledwas dropped. It existed previously so that users could flip off even in-memory metrics collection, leaving an empty CompositeMeterRegistry that was essentially a NOOP (seeCompositeMeterRegistryPostProcessorTests#registerWhenHasNoMeterRegistryShouldRegisterEmptyComposite).See #12089 (comment)