Remove config options from Rabbit/JDBC/Cache metrics #12017
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jkschneider
force-pushed
the
micrometer-config
branch
from
6bf2d37 to
7c9ef82
Compare
snicoll
approved these changes
Feb 13, 2018
snicoll
added
type: enhancement
snicoll
pushed a commit
that referenced
this pull request
Feb 13, 2018
snicoll
added a commit
that referenced
this pull request
Feb 13, 2018
* pr/12017: Polish "Remove unnecessary config options for metrics" Remove unnecessary config options for JDBC, Rabbit, and Cache metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OOTB Micrometer binders all now use a consistent prefix so they are easy to configure with
MeterFilters. Previously, in some binders, we allowed the user to provide a name that was used as the metric prefix. In those cases (such asDataSourcePoolMetrics), we've moved the name to a tag. This improves the dimensional exploration of data source metrics while improving the application ofMeterFilters as well.Once these binders have a consistent prefix (e.g.
jdbcforDataSourcePoolMetrics,rabbitmqforRabbitMetrics), and since we now have #11800, we no longer need*.instrumentproperty flags on these OOTB binders. It is sufficient to usemanagement.metrics.enable.jdbc=falseto JDBC metrics, for example.If the user does insist on changing the metric name prefix, it is possible to do with a programmatic
MeterFilterusingMeterFilter#map.