Replace Narayana JDBC with Commons DBCP2 #12000
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks for the PR.
Unfortunately, I think this change is too big to go into 1.5. Previously, we'd talked about the Narayana auto-configuration moving out of Boot. Perhaps this change is further motivation for that move? There's probably just about time to do that in 2.0. |
wilkinsona
added
the
status: waiting-for-feedback
gytis
force-pushed
the
master-tomcat-jdbc
branch
from
f56bcdb to
2afa3c8
Compare
|
Thanks for your feedback @wilkinsona. Since we need this feature to work with both versions, I'll go ahead and start creating a separate project for Narayana starter. |
snicoll
removed
status: waiting-for-feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace Narayana JDBC driver with commons-dbcp2 and commons-pool2 to take advantage of a connection pooling support when using Narayana.
We would like to introduce this change to 1.5.x branch too.
cc @zhfeng and @tomjenkinson from Narayana project.