-
Notifications
You must be signed in to change notification settings - Fork 41.6k
Add out-of-the-box health indicator for reactive MongoDB #11997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
0cd1467
dff7a49
341b400
35a7764
47a74a9
b55ef3c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| /* | ||
| * Copyright 2012-2018 the original author or authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.springframework.boot.actuate.autoconfigure.mongo; | ||
|
|
||
| import java.util.Map; | ||
|
|
||
| import org.springframework.boot.actuate.autoconfigure.health.CompositeReactiveHealthIndicatorConfiguration; | ||
| import org.springframework.boot.actuate.autoconfigure.health.ConditionalOnEnabledHealthIndicator; | ||
| import org.springframework.boot.actuate.autoconfigure.health.HealthIndicatorAutoConfiguration; | ||
| import org.springframework.boot.actuate.health.ReactiveHealthIndicator; | ||
| import org.springframework.boot.actuate.mongo.MongoReactiveHealthIndicator; | ||
| import org.springframework.boot.autoconfigure.AutoConfigureAfter; | ||
| import org.springframework.boot.autoconfigure.AutoConfigureBefore; | ||
| import org.springframework.boot.autoconfigure.EnableAutoConfiguration; | ||
| import org.springframework.boot.autoconfigure.condition.ConditionalOnBean; | ||
| import org.springframework.boot.autoconfigure.condition.ConditionalOnClass; | ||
| import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean; | ||
| import org.springframework.boot.autoconfigure.data.mongo.MongoReactiveDataAutoConfiguration; | ||
| import org.springframework.boot.autoconfigure.mongo.MongoReactiveAutoConfiguration; | ||
| import org.springframework.context.annotation.Bean; | ||
| import org.springframework.context.annotation.Configuration; | ||
| import org.springframework.data.mongodb.core.ReactiveMongoTemplate; | ||
|
|
||
|
|
||
|
|
||
| /** | ||
| * {@link EnableAutoConfiguration Auto-configuration} for {@link MongoReactiveHealthIndicator}. | ||
| * | ||
| * @author Yulin Qin | ||
| * @since 2.0.0 | ||
| */ | ||
| @Configuration | ||
| @ConditionalOnClass(ReactiveMongoTemplate.class) | ||
| @ConditionalOnBean(ReactiveMongoTemplate.class) | ||
| @ConditionalOnEnabledHealthIndicator("mongo") | ||
| @AutoConfigureBefore(HealthIndicatorAutoConfiguration.class) | ||
| @AutoConfigureAfter({MongoReactiveAutoConfiguration.class, MongoReactiveDataAutoConfiguration.class}) | ||
|
||
| public class MongoReactiveHealthIndicatorAutoConfiguration extends | ||
| CompositeReactiveHealthIndicatorConfiguration<MongoReactiveHealthIndicator, ReactiveMongoTemplate> { | ||
|
|
||
| private final Map<String, ReactiveMongoTemplate> reactiveMongoTemplate; | ||
|
|
||
| public MongoReactiveHealthIndicatorAutoConfiguration( | ||
| Map<String, ReactiveMongoTemplate> reactiveMongoTemplate) { | ||
| this.reactiveMongoTemplate = reactiveMongoTemplate; | ||
| } | ||
|
|
||
| @Bean | ||
| @ConditionalOnMissingBean(name = "mongoReactiveHealthIndicator") | ||
| public ReactiveHealthIndicator mongoReactiveHealthIndicator() { | ||
| return createHealthIndicator(this.reactiveMongoTemplate); | ||
| } | ||
|
|
||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| /* | ||
| * Copyright 2012-2018 the original author or authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.springframework.boot.actuate.autoconfigure.mongo; | ||
|
|
||
| import org.junit.Test; | ||
|
|
||
| import org.springframework.boot.actuate.autoconfigure.health.HealthIndicatorAutoConfiguration; | ||
| import org.springframework.boot.actuate.health.ApplicationHealthIndicator; | ||
| import org.springframework.boot.actuate.mongo.MongoHealthIndicator; | ||
| import org.springframework.boot.actuate.mongo.MongoReactiveHealthIndicator; | ||
| import org.springframework.boot.autoconfigure.AutoConfigurations; | ||
| import org.springframework.boot.autoconfigure.data.mongo.MongoDataAutoConfiguration; | ||
| import org.springframework.boot.autoconfigure.data.mongo.MongoReactiveDataAutoConfiguration; | ||
| import org.springframework.boot.autoconfigure.mongo.MongoAutoConfiguration; | ||
| import org.springframework.boot.autoconfigure.mongo.MongoReactiveAutoConfiguration; | ||
| import org.springframework.boot.test.context.runner.ApplicationContextRunner; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| /** | ||
| * Tests for {@link MongoReactiveHealthIndicatorAutoConfiguration} | ||
| * | ||
| * @author Yulin Qin | ||
| */ | ||
| public class MongoReactiveHealthIndicatorAutoConfigurationTests { | ||
|
|
||
| private ApplicationContextRunner contextRunner = new ApplicationContextRunner() | ||
| .withConfiguration(AutoConfigurations.of( | ||
| MongoAutoConfiguration.class, | ||
| MongoDataAutoConfiguration.class, | ||
| MongoReactiveAutoConfiguration.class, | ||
| MongoReactiveDataAutoConfiguration.class, | ||
| MongoReactiveHealthIndicatorAutoConfiguration.class, | ||
| HealthIndicatorAutoConfiguration.class)); | ||
|
|
||
| @Test | ||
| public void runShouldCreateIndicator() { | ||
| this.contextRunner.run( | ||
| (context) -> assertThat(context).hasSingleBean(MongoReactiveHealthIndicator.class) | ||
| .doesNotHaveBean(MongoHealthIndicator.class) | ||
| .doesNotHaveBean(ApplicationHealthIndicator.class)); | ||
| } | ||
|
|
||
| @Test | ||
| public void runWhenDisabledShouldNotCreateIndicator() { | ||
| this.contextRunner.withPropertyValues("management.health.mongo.enabled:false") | ||
| .run((context) -> assertThat(context) | ||
| .doesNotHaveBean(MongoReactiveHealthIndicator.class) | ||
| .doesNotHaveBean(MongoHealthIndicator.class) | ||
| .hasSingleBean(ApplicationHealthIndicator.class)); | ||
| } | ||
|
|
||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| /* | ||
| * Copyright 2012-2018 the original author or authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.springframework.boot.actuate.mongo; | ||
|
|
||
| import org.bson.Document; | ||
| import reactor.core.publisher.Mono; | ||
|
|
||
| import org.springframework.boot.actuate.health.AbstractReactiveHealthIndicator; | ||
| import org.springframework.boot.actuate.health.Health; | ||
| import org.springframework.boot.actuate.health.ReactiveHealthIndicator; | ||
| import org.springframework.data.mongodb.core.ReactiveMongoTemplate; | ||
| import org.springframework.util.Assert; | ||
|
|
||
|
|
||
|
|
||
| /** | ||
| * A {@link ReactiveHealthIndicator} for Mongo. | ||
| * | ||
| * @author Yulin Qin | ||
| * @since 2.0.0 | ||
| */ | ||
| public class MongoReactiveHealthIndicator extends AbstractReactiveHealthIndicator { | ||
|
|
||
| private final ReactiveMongoTemplate reactiveMongoTemplate; | ||
|
|
||
| public MongoReactiveHealthIndicator(ReactiveMongoTemplate reactiveMongoTemplate) { | ||
| Assert.notNull(reactiveMongoTemplate, "ReactiveMongoTemplate must not be null"); | ||
| this.reactiveMongoTemplate = reactiveMongoTemplate; | ||
| } | ||
|
|
||
| @Override | ||
| protected Mono<Health> doHealthCheck(Health.Builder builder) { | ||
| Mono<Document> documentMono = this.reactiveMongoTemplate.executeCommand("{ buildInfo: 1 }"); | ||
| return documentMono.map(document -> up(builder, document)); | ||
| } | ||
|
|
||
| private Health up(Health.Builder builder, Document document) { | ||
| return builder.up().withDetail("version", document.getString("version")).build(); | ||
| } | ||
| } | ||
|
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| /* | ||
| * Copyright 2012-2018 the original author or authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.springframework.boot.actuate.mongo; | ||
|
|
||
| import com.mongodb.MongoException; | ||
| import org.bson.Document; | ||
| import org.junit.Test; | ||
| import reactor.core.publisher.Mono; | ||
| import reactor.test.StepVerifier; | ||
|
|
||
| import org.springframework.boot.actuate.health.Health; | ||
| import org.springframework.boot.actuate.health.Status; | ||
| import org.springframework.data.mongodb.core.ReactiveMongoTemplate; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
| import static org.mockito.BDDMockito.given; | ||
| import static org.mockito.Mockito.mock; | ||
|
|
||
| /** | ||
| * Tests for {@link MongoReactiveHealthIndicator}. | ||
| * | ||
| * @author Yulin Qin | ||
| */ | ||
|
|
||
|
||
| public class MongoReactiveHealthIndicatorTest { | ||
| private MongoReactiveHealthIndicator mongoReactiveHealthIndicator; | ||
|
||
|
|
||
| @Test | ||
| public void testMongoIsUp() throws Exception { | ||
| Document document = mock(Document.class); | ||
| ReactiveMongoTemplate reactiveMongoTemplate = mock(ReactiveMongoTemplate.class); | ||
| given(reactiveMongoTemplate.executeCommand("{ buildInfo: 1 }")).willReturn(Mono.just(document)); | ||
| given(document.getString("version")).willReturn("2.6.4"); | ||
|
|
||
| this.mongoReactiveHealthIndicator = new MongoReactiveHealthIndicator(reactiveMongoTemplate); | ||
| Mono<Health> health = this.mongoReactiveHealthIndicator.health(); | ||
| StepVerifier.create(health).consumeNextWith((h) -> { | ||
| assertThat(h.getStatus()).isEqualTo(Status.UP); | ||
| assertThat(h.getDetails()).containsOnlyKeys("version"); | ||
| assertThat(h.getDetails().get("version")).isEqualTo("2.6.4"); | ||
| }).verifyComplete(); | ||
| } | ||
|
|
||
| @Test | ||
| public void testMongoIsDown() throws Exception { | ||
| ReactiveMongoTemplate reactiveMongoTemplate = mock(ReactiveMongoTemplate.class); | ||
| given(reactiveMongoTemplate.executeCommand("{ buildInfo: 1 }")).willThrow(new MongoException("Connection failed")); | ||
|
|
||
| this.mongoReactiveHealthIndicator = new MongoReactiveHealthIndicator(reactiveMongoTemplate); | ||
| Mono<Health> health = this.mongoReactiveHealthIndicator.health(); | ||
| StepVerifier.create(health).consumeNextWith((h) -> { | ||
| assertThat(h.getStatus()).isEqualTo(Status.DOWN); | ||
| assertThat(h.getDetails()).containsOnlyKeys("error"); | ||
| assertThat(h.getDetails().get("error")).isEqualTo("Connection failed"); | ||
| }).verifyComplete(); | ||
|
|
||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| /* | ||
| * Copyright 2012-2017 the original author or authors. | ||
| * Copyright 2012-2018 the original author or authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
|
|
@@ -32,6 +32,7 @@ | |
| import org.springframework.data.mongodb.core.SimpleReactiveMongoDatabaseFactory; | ||
| import org.springframework.data.mongodb.core.convert.MongoConverter; | ||
|
|
||
|
|
||
| /** | ||
| * {@link EnableAutoConfiguration Auto-configuration} for Spring Data's reactive mongo | ||
| * support. | ||
|
|
@@ -43,12 +44,13 @@ | |
| * to the {@literal test} database. | ||
| * | ||
| * @author Mark Paluch | ||
| * @author Yulin Qin | ||
| * @since 2.0.0 | ||
| */ | ||
| @Configuration | ||
| @ConditionalOnClass({ MongoClient.class, ReactiveMongoTemplate.class }) | ||
| @EnableConfigurationProperties(MongoProperties.class) | ||
| @AutoConfigureAfter(MongoReactiveAutoConfiguration.class) | ||
| @AutoConfigureAfter({ MongoReactiveAutoConfiguration.class, MongoDataAutoConfiguration.class }) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please rebase your PR rather than changing something that has already been changed.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
| public class MongoReactiveDataAutoConfiguration { | ||
|
|
||
| private final MongoProperties properties; | ||
|
|
@@ -72,5 +74,4 @@ public ReactiveMongoTemplate reactiveMongoTemplate( | |
| MongoConverter converter) { | ||
| return new ReactiveMongoTemplate(reactiveMongoDatabaseFactory, converter); | ||
| } | ||
|
|
||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't sorted properly still (m is before s)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done