DataSourceHealthIndicator need timeout

[bohrqiu]

for the business function，we will set database timeout(get connent form pool time out or exec query wait time out ) very long ,but It's not appropriate for HealthIndicator. in HealthIndicator，We just check whether the connection is available. so we should add timeout for HealthIndicator,as DataSourceHealthIndicator an example

https://gist.github.com/bohrqiu/094e6e22a56b684fcec8

[bohrqiu]

We'd better add timeout on org.springframework.boot.actuate.health.AbstractHealthIndicator#health method，all HealthIndicator can timeout

[philwebb]

We're cleaning out the issue tracker and closing issues that we've not seen much demand to fix. Feel free to comment with additional justifications if you feel that this one should not have been closed.

[philwebb]

It's also worth noting that as of 2.0 there is caching with health endpoints and the option of a custom TTL

[kostellodon]

Sorry, don't know the etiquette, if leaving a comment here vs creating a new issue is preferred. This is something that we need. We have a spring boot app deployed to a container (cloud foundry) that gets intermittent health check failures due to the endpoint not responding. We see no exceptions in our logs, so I'm assuming one of the health check components is taking too long to respond, but we have no way of knowing which one. Having a timeout on the health check indicators would help us track down what is causing our intermittent failures.

[philwebb]

@kostellodon Timeout support is going to be quite hard for us to implement, but your use-case makes me think that we should try to improve our logging. I've opened #31231 to track that.