Properties file precedence - issue while switching to JAVA 8

[nsdiv]

Hi,
Found an issue while switching from JAVA 7 to JAVA 8. The order of profile properties that are defined in both yml and properties file is switched.

The working sample is posted here, with steps to reproduce:
https://github.com/nsdiv/spring-boot-java8-java7-prop-loading

Specifically, we're using spring boot version 1.2.3.RELEASE, but can reproduce this issue in 1.2.6.RELEASE as well

[shrisha]

Another sample (with less dependencies) that demonstrates the issue: https://github.com/shrisha/spring-boot-config-precedence

when you run the sample app against 1.7 and then 1.8, you'll notice the following difference in property loading order:

Java 1.7

2015-10-07 21:07:31.783 DEBUG 1453 --- [ main] o.s.core.env.StandardEnvironment : Adding [applicationConfig: [classpath:/application-test.properties]] PropertySource with search precedence immediately lower than [applicationConfigurationProperties]

2015-10-07 21:07:31.784 DEBUG 1453 --- [ main] o.s.core.env.StandardEnvironment : Adding [applicationConfig: [classpath:/application.yml]#test] PropertySource with search precedence immediately lower than [applicationConfig: [classpath:/application-test.properties]]

2015-10-07 21:07:31.784 DEBUG 1453 --- [ main] o.s.core.env.StandardEnvironment : Adding [applicationConfig: [classpath:/application.yml]#default] PropertySource with search precedence immediately lower than [applicationConfig: [classpath:/application.yml]#test]

2015-10-07 21:07:31.784 DEBUG 1453 --- [ main] o.s.core.env.StandardEnvironment : Adding [applicationConfig: [classpath:/application.yml]] PropertySource with search precedence immediately lower than [applicationConfig: [classpath:/application.yml]#default]

Java 1.8

2015-10-07 21:00:35.110 DEBUG 1416 --- [ main] o.s.core.env.StandardEnvironment : Adding [applicationConfig: [classpath:/application.yml]#test] PropertySource with search precedence immediately lower than [applicationConfigurationProperties]

2015-10-07 21:00:35.110 DEBUG 1416 --- [ main] o.s.core.env.StandardEnvironment : Adding [applicationConfig: [classpath:/application-test.properties]] PropertySource with search precedence immediately lower than [applicationConfig: [classpath:/application.yml]#test]

2015-10-07 21:00:35.110 DEBUG 1416 --- [ main] o.s.core.env.StandardEnvironment : Adding [applicationConfig: [classpath:/application.yml]#default] PropertySource with search precedence immediately lower than [applicationConfig: [classpath:/application-test.properties]]

2015-10-07 21:00:35.111 DEBUG 1416 --- [ main] o.s.core.env.StandardEnvironment : Adding [applicationConfig: [classpath:/application.yml]] PropertySource with search precedence immediately lower than [applicationConfig: [classpath:/application.yml]#default]

[dsyer]

It's pretty unusual to use properties and yaml files in the same project and with profile specific overrides for the same profile in both. So I think this is an edge case (hence I marked as "enhancement") but we can fix it because it is all to do with the ordering of supported file extensions (using a plain HashSet: https://github.com/spring-projects/spring-boot/blob/master/spring-boot/src/main/java/org/springframework/boot/env/PropertySourcesLoader.java#L202).

[shrisha]

thanks for the quick fingers, @dsyer!