2 different versions of jboss-transaction-api

[BigMichi1]

we have these dependencies declared in our pom.xml

org.springframework.boot:spring-boot-starter-data-jpa:jar:1.2.0.BUILD-SNAPSHOT:compile
and
org.hornetq:hornetq-jms-server:jar:2.4.5.Final:compile

this results of being two different versions of the jboss-transaction-api are included version 1.1 and 1.2 in the resulting war file

[INFO] +- org.hornetq:hornetq-jms-server:jar:2.4.5.Final:compile
[INFO] |  +- org.hornetq:hornetq-core-client:jar:2.4.5.Final:compile
[INFO] |  |  +- org.jgroups:jgroups:jar:3.3.4.Final:compile
[INFO] |  |  +- org.hornetq:hornetq-commons:jar:2.4.5.Final:compile
[INFO] |  |  +- org.hornetq:hornetq-journal:jar:2.4.5.Final:compile
[INFO] |  |  |  \- org.hornetq:hornetq-native:jar:2.4.5.Final:compile
[INFO] |  |  \- io.netty:netty-all:jar:4.0.13.Final:compile
[INFO] |  +- org.hornetq:hornetq-server:jar:2.4.5.Final:compile
[INFO] |  +- org.jboss.spec.javax.jms:jboss-jms-api_2.0_spec:jar:1.0.0.Final:compile
[INFO] |  +- org.jboss.spec.javax.transaction:jboss-transaction-api_1.1_spec:jar:1.0.0.Final:compile

[INFO] +- org.springframework.boot:spring-boot-starter-data-jpa:jar:1.2.0.BUILD-SNAPSHOT:compile
[INFO] |  +- org.springframework.boot:spring-boot-starter-aop:jar:1.2.0.BUILD-SNAPSHOT:compile
[INFO] |  |  +- org.aspectj:aspectjrt:jar:1.8.4:compile
[INFO] |  |  \- org.aspectj:aspectjweaver:jar:1.8.4:compile
[INFO] |  +- org.springframework.boot:spring-boot-starter-jdbc:jar:1.2.0.BUILD-SNAPSHOT:compile
[INFO] |  |  +- org.springframework:spring-jdbc:jar:4.1.3.BUILD-SNAPSHOT:compile
[INFO] |  |  +- org.apache.tomcat:tomcat-jdbc:jar:8.0.15:compile
[INFO] |  |  |  \- org.apache.tomcat:tomcat-juli:jar:8.0.15:compile
[INFO] |  |  \- org.springframework:spring-tx:jar:4.1.3.BUILD-SNAPSHOT:compile
[INFO] |  +- org.hibernate:hibernate-entitymanager:jar:4.3.7.Final:compile
[INFO] |  |  +- org.jboss.logging:jboss-logging-annotations:jar:1.2.0.Beta1:compile
[INFO] |  |  +- org.hibernate:hibernate-core:jar:4.3.7.Final:compile
[INFO] |  |  |  +- antlr:antlr:jar:2.7.7:compile
[INFO] |  |  |  \- org.jboss:jandex:jar:1.1.0.Final:compile
[INFO] |  |  +- dom4j:dom4j:jar:1.6.1:compile
[INFO] |  |  |  \- xml-apis:xml-apis:jar:1.4.01:compile
[INFO] |  |  +- org.hibernate.common:hibernate-commons-annotations:jar:4.0.5.Final:compile
[INFO] |  |  +- org.hibernate.javax.persistence:hibernate-jpa-2.1-api:jar:1.0.0.Final:compile
[INFO] |  |  +- org.jboss.spec.javax.transaction:jboss-transaction-api_1.2_spec:jar:1.0.0.Final:compile

perhaps to avoid such problems the parent pom should define the enforcer-plugin to find such version mismatches

            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-enforcer-plugin</artifactId>
                <version>1.3.1</version>
                <configuration>
                    <rules>
                        <DependencyConvergence/>
                    </rules>
                </configuration>
                <executions>
                    <execution>
                        <id>enforce</id>
                        <goals>
                            <goal>enforce</goal>
                        </goals>
                    </execution>
                </executions>
            </plugin>

[snicoll]

Interesting, I would have thought that Hibernate and HornetQ would converge on those. Might be worth understanding why it's not aligned. Thanks for the tip on dependency convergence, worth a watch indeed.

@philwebb I think this is something we should fix for 1.2 still. I'll have a look today.

[wilkinsona]

This is a fine example of why it's a bad idea to include version numbers in an artifact ID.

Ideally, we'd exclude the JBoss JTA dependency entirely and use the "official" JTA API instead: http://repo1.maven.org/maven2/javax/transaction/javax.transaction-api/

[snicoll]

I like that. @wilkinsona do you think we should do this before the release?

[wilkinsona]

I'm on PTO today but wanted to voice an opinion on this as it affects Spring IO.

We already have dependency management for the official artifact in Spring IO. Whatever we do in Boot, I don't want to end up with dependency management for two different JTA API artifacts.

It looks like we need to do something. Using the official artifact across the board feels like the right thing to me.

[snicoll]

alright, I'll propose a PR today so that someone else (not you :) ) can review. Thanks for replying!

[snicoll]

I raised the issue on the HornetQ project: https://issues.jboss.org/browse/HORNETQ-1452

[snicoll]

the problem is that hornetq-jms-server is a dep that you add yourself so you can't handle that in the starter. I'll investigate if we can mitigate this.

Hibernate has a hard dependency on JTA so we can't really exclude it. But we can at least replace the jar with the standard library.

[snicoll]

Our own JTA support may suffer from the same issue. I don't know for Atomikos but the bitronix starter brings javax.transaction:jta:1.1

Let's postpone that to the point release as this requires more thinking. This is what I got so far:

• JTA api is required by Hibernate so we can exclude it from the spring-boot-starter-data-jpa
• It's unclear how HornetQ is using it but we should get an answer via the issue I've created
• BTM should run fine with JTA 1.2 so we should add some exclusion there to bring a curated dependency
• Atomikos still needs to be checked

[snicoll]

Here's what we got:

• BTM relies on JTA 1.1 but using 1.2 shouldn't be a problem
• HornetQ does not require the JTA API, it's a dependency issue on their end so we can exclude it
• Hibernate brings JTA 1.2 but a different artifact so we'll have to manage it
• Atomikos does not bring JTA at all. Users should probably add that themselves I guess (ping @philwebb). It used to be there (thanks @lorban!) so we should add it in the starter